Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banner placement exception breaking flags #994

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

Pablete1234
Copy link
Member

Fixes #992

The issue was that when a banner was placed, it caused block updates which could cause that newly placed banner to pop-out, causing a cast exception when trying to use the block metadata as a banner.

This pr addresses the issue in 2 ways:

  • Do not apply physics when placing banners, this removes the block updates that pop-out the banner
  • Check if the block state is a banner before doing anything with it. This prevents the exception that could cause the banner to become unpickable (since label entity doesn't get to initialize).

@Pablete1234 Pablete1234 added the bug Something isn't working label Apr 22, 2022
@Electroid Electroid merged commit 72e76e8 into dev Apr 22, 2022
@Electroid Electroid deleted the banner-place-fix branch April 22, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants