Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more kit information #968

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Expose more kit information #968

merged 1 commit into from
Feb 20, 2022

Conversation

Pablete1234
Copy link
Member

Exposes if the kit is being forced or not on the kit apply event, as well as allowing forced flag to be changed

Exposes what a clear kit is actually clearing

@Pablete1234
Expose more kit information
14b6115 
Signed-off-by: Pablo Herrera <[email protected]>
@KingOfSquares
Copy link
Contributor

The setForce addition feels like something that could lead to unexpected behaviour if any plugin could edit it without server owners knowing. Thoughts? Maybe it could be logged per-match at low level or something?

@Pablete1234
Copy link
Member Author

Pablete1234 commented Feb 18, 2022 •
edited
Loading

I don't think a plugin being able to change the force flag is unexpected behavior, i think it adds flexibility although i generally do not think it should be used

@Electroid Electroid merged commit b734ac5 into dev Feb 20, 2022
@Electroid Electroid deleted the kit-improvements branch February 20, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pablete1234 @KingOfSquares @Electroid