Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check FireTick during match load and start #879

Merged
merged 25 commits into from
Sep 4, 2021
Merged

Check FireTick during match load and start #879

merged 25 commits into from
Sep 4, 2021

Conversation

CoWinkKeyDinkInc
Copy link
Contributor

While I was helping @technodono find out why The Dropper Community map was damaged, I discovered that fire spreads before the match starts. This PR fixes this simple bug to make it consistent with other world events, like PGM locking mob movement and time. DoFireTick will now default to on (as it always has) when the match starts.

@CoWinkKeyDinkInc
Copy link
Contributor Author

This PR now adds gamerules set by level.dat not mentioned by <gamemode> into the GameRulesMatchModule, so now it takes gamemodes intentionally set in level.dat to account.

@CoWinkKeyDinkInc
Copy link
Contributor Author

CoWinkKeyDinkInc commented Aug 3, 2021 •
edited
Loading

Currently in this PR maps that have doDayLightCycle set to true in the gamerule XML do not get the sun moving. Intercept specifically has this on.

<gamerules>
    <doDaylightCycle>true</doDaylightCycle>
</gamerules>

@CoWinkKeyDinkInc
Copy link
Contributor Author

This PR is in working order now.

@Electroid Electroid merged commit efc9aa5 into PGMDev:dev Sep 4, 2021
@calcastor calcastor mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pablete1234 Pablete1234 Pablete1234 approved these changes

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoWinkKeyDinkInc @Electroid @Pablete1234