Add a match state filter #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proto 1.4.2 added filters that allow you to check the match state. These can be found under the Matcher Elements section and are Not sure why one implementation would be favoured over another (others may able to comment) but you should probs add the ability to define them in that way to bring us closer to that sweet sweet 1.4.2 support. |
|
https://github.com/OvercastNetwork/ProjectAres/blob/master/PGM/src/main/java/tc/oc/pgm/filters/parser/FilterDefinitionParser.java#L463 |
KingOfSquares
force-pushed
the
match-state-filter
branch
from
918fb63
to
c8fe28b
Compare
Pablete1234
requested changes
Nov 3, 2020
Electroid
requested changes
Nov 4, 2020
Electroid
requested changes
Nov 11, 2020
Electroid
previously approved these changes
Nov 29, 2020
KingOfSquares
force-pushed
the
match-state-filter
branch
from
0eaaab8
to
1c4874c
Compare
Pablete1234
requested changes
Dec 12, 2020
Signed-off-by: KingSimon <[email protected]>
Signed-off-by: KingSimon <[email protected]>
- Rework logic Signed-off-by: KingSimon <[email protected]>
Signed-off-by: KingSimon <[email protected]>
Signed-off-by: KingSimon <[email protected]>
Signed-off-by: KingSimon <[email protected]>
KingOfSquares
force-pushed
the
match-state-filter
branch
from
1c4874c
to
edc9769
Compare
Pablete1234
approved these changes
Dec 27, 2020
|
@Electroid could we get this merged? |
Electroid
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I didn't test I wanted to get this in time for Hacktoberfest, will of course test before its mergedIt already ended 🤦
Signed-off-by: KingSimon [email protected]