Make item matching ignore modifier uuids #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <[email protected]>
cswhite2000
approved these changes
Nov 6, 2024
| boolean attributesEqual(ItemMeta meta1, ItemMeta meta2); | ||
|
|
||
| default boolean modifiersDiffer( | ||
| Collection<AttributeModifier> a, Collection<AttributeModifier> b) { |
There was a problem hiding this comment.
nit: style: imo this method is going too far with shortening variables names and makes it a bit harder to follow
Admittedly its less of a problem here given that what the method does is pretty simple
There was a problem hiding this comment.
the method is rather trivial, so it's either A and B or modifiersA modifiersB, or modifiers1, modifiers2
given how trivial it is i don't think it matters much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1167
Essentially makes it so item-matching in PGM checks attribute modifiers ignoring their UUID, and if they're all equal then strips the modifiers from the meta that is passed down to the "equals" check