Refactor channels #1423
Draft
Refactor channels #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Jeffcock <[email protected]>
Pugzy
force-pushed
the
rebased-channels
branch
from
816ef4e
to
51a6564
Compare
Pablete1234
requested changes
Nov 6, 2024
| } | ||
|
|
||
| public void setChannel(MatchPlayer player, Channel<?> channel) { | ||
| Channel<?> previous = selectedChannel.get(player.getId()); |
There was a problem hiding this comment.
No need to get & put, put already gives you previous value
| return; | ||
| } | ||
|
|
||
| context.store(MESSAGE_KEY, message.substring(spaceIndex + 1)); |
There was a problem hiding this comment.
Missing a trim() after the substring
| } | ||
|
|
||
| public static void playSound(MatchPlayer player, Sound sound) { | ||
| SettingValue value = player.getSettings().getValue(SettingKey.SOUNDS); | ||
| if (value.equals(SettingValue.SOUNDS_ALL) | ||
| || value.equals(SettingValue.SOUNDS_CHAT) | ||
| || (sound.equals(Sounds.DIRECT_MESSAGE) && value.equals(SettingValue.SOUNDS_DM))) { | ||
| || (sound.equals(DM_SOUND) && value.equals(SettingValue.SOUNDS_DM))) { |
There was a problem hiding this comment.
Does this in chat dispatcher even make sense anymore?
calcastor
reviewed
Nov 7, 2024
| private static final String PREFIX_FORMAT = "%s: %s"; | ||
| private static final String AC_FORMAT = | ||
| TextTranslations.translateLegacy(ADMIN_CHAT_PREFIX) + PREFIX_FORMAT; | ||
| private static final Sound DM_SOUND = sound(key("random.orb"), Sound.Source.MASTER, 1f, 1.2f); |
There was a problem hiding this comment.
Import Sounds.DIRECT_MESSAGE from the Sounds interface if it's needed; slipped through rebase?
There was a problem hiding this comment.
chat dispatcher is only kept for backwards-compat, it should simply not have any of this left
Pablete1234
reviewed
Nov 7, 2024
|
|
||
| private final OnlinePlayerUUIDMapAdapter<MessageSenderIdentity> selectedPlayer, lastMessagedBy; | ||
|
|
||
| private static final Sound SOUND = sound(key("random.orb"), Sound.Source.MASTER, 1f, 1.2f); |
There was a problem hiding this comment.
This however, yeah, it should reference Sounds for multi-version support
Pablete1234
reviewed
Nov 7, 2024
| .append(text("] ", NamedTextColor.WHITE)) | ||
| .build(); | ||
|
|
||
| private static final Sound SOUND = sound(key("random.orb"), Sound.Source.MASTER, 1f, 0.7f); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1306 updated to new cloudy framework