-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Score & team-rescoping variables #1220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
force-pushed
the
score-variable
branch
from
August 19, 2023 10:55
01ee08d
to
a931d3c
Compare
Closed
Pablete1234
force-pushed
the
score-variable
branch
from
August 19, 2023 14:00
767d709
to
f80d6bb
Compare
7 tasks
cswhite2000
previously approved these changes
Aug 22, 2023
Electroid
previously approved these changes
Aug 23, 2023
Conflicts need to be resolved, but lgtm. |
Signed-off-by: Pablo Herrera <[email protected]>
Pablete1234
dismissed stale reviews from Electroid and cswhite2000
via
August 23, 2023 18:25
f77da9f
Pablete1234
force-pushed
the
score-variable
branch
2 times, most recently
from
August 23, 2023 18:26
f77da9f
to
4722115
Compare
Signed-off-by: Pablo Herrera <[email protected]>
Pablete1234
force-pushed
the
score-variable
branch
from
August 23, 2023 18:27
4722115
to
1628265
Compare
@Electroid conflicts fixed, please re-review to merge. This is now urgent as dev branch has a broken syntax for variables that we don't want map authors relying upon |
cswhite2000
approved these changes
Aug 23, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1214 being merged first.
Implements score variable, which is a way to directly access (read/write) a competitor's score. The variable is scoped to team.
<score id="team_score" />
Also implements a team-rescoping variable, which allows using a specific teams' value from a team-scoped variable, as a match-scoped variable.
<with-team id="red_team_score" var="team_score" team="red"/>
A more fully-fledged example:
Whenever some-filter matches for a player (eg: entering a region), it will trigger an action that sets red team's score to exactly 10, then adds 5 to the score of the team the player is in.
In other words, if a player in red team triggers some-filter, red is reset to 10 + 5 = 15, no other scores are affected.
if a player in blue team triggers some-filter, red is reset to 10, and blue wins 5 points.