Update legacy region parsing logic #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pugzy <[email protected]>
Pugzy
force-pushed
the
max-build-changes
branch
from
9a6fa51
to
fc16896
Compare
Pablete1234
approved these changes
Oct 15, 2022
Electroid
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some erroneous wording changes made by a certain king of shapes which has since made its way in to the docs.
The
laneselement was incorrectly listed as deprecated rather than legacy. Although true that lanes are no longer the recommended way to apply this logic it is still valid XML in the current protocol.The same extends to
maxbuildheightwhich is still the recommended way of applying this logic. The creation of this feature is moved to a half-space region (as would be expected) rather than an infinitely sized cuboid.The
playableelement is no longer supported in the current protocol (as of 1.3.6). This change adds a proto-check before parsing this element. As indicated on the following page http://docs.oc.tc/modules/proto.If accepted I can make a PR to the docs to resolve the deprecated notice of Build Height.
Signed-off-by: Pugzy [email protected]