-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework map pools & add map vote picker #1010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electroid
reviewed
Jun 5, 2022
calcastor
reviewed
Jun 6, 2022
Electroid
requested changes
Jun 6, 2022
Signed-off-by: Pablete1234 <[email protected]>
Signed-off-by: Pablete1234 <[email protected]>
Signed-off-by: Pablete1234 <[email protected]>
Signed-off-by: Pablete1234 <[email protected]>
Signed-off-by: Pablete1234 <[email protected]>
Electroid
previously approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but minor changed requested.
Signed-off-by: Pablete1234 <[email protected]>
Electroid
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for landing these improvements! Excited 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks a few aspects in map pools, and makes the voted pool use a
MapVotePicker
to decide what maps go on the vote, as well as handling the score to weight conversion via a custom formula defined in the config.This extra step allows for arbitrary modifications to score for extra functionality such as: