Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework map pools & add map vote picker #1010

Merged
merged 6 commits into from
Jul 15, 2022
Merged

Rework map pools & add map vote picker #1010

merged 6 commits into from
Jul 15, 2022

Conversation

Pablete1234
Copy link
Member

@Pablete1234 Pablete1234 commented Jun 5, 2022

Reworks a few aspects in map pools, and makes the voted pool use a MapVotePicker to decide what maps go on the vote, as well as handling the score to weight conversion via a custom formula defined in the config.
This extra step allows for arbitrary modifications to score for extra functionality such as:

  • lowering weights for gamemodes that already got representation on the vote (eg: if first map is CTW, CTW is less likely to appear in the following picks)
  • Current online playercount to map size ratio (prefer playing maps of proper size over wrongly-sized ones).
  • Allow tweaking via config values all of the internal dials that affect this, so they can be fine-tuned in production

@Pablete1234 Pablete1234 added the feature New feature or request label Jun 5, 2022
core/src/main/resources/map-pools.yml Outdated Show resolved Hide resolved
Electroid
Electroid previously approved these changes Jul 14, 2022
Copy link
Member

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but minor changed requested.

core/src/main/java/tc/oc/pgm/rotation/vote/Formula.java Outdated Show resolved Hide resolved
core/src/main/resources/map-pools.yml Show resolved Hide resolved
core/src/main/resources/map-pools.yml Show resolved Hide resolved
Copy link
Member

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for landing these improvements! Excited 🎉

@Electroid Electroid merged commit a5b7178 into dev Jul 15, 2022
@Electroid Electroid deleted the pool-rework branch July 15, 2022 13:31
@Pablete1234 Pablete1234 mentioned this pull request Nov 5, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants