Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the readme file #81

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Refactor the readme file #81

merged 7 commits into from
Jan 24, 2024

Conversation

WhiteSte
Copy link
Contributor

Macos arm users who want to use pdal-java cannot use directly the maven published jars because they are missing arm native libs. Added a guide for a self build

@WhiteSte
Copy link
Contributor Author

I've refactored completely the structure of the readme file in order to be more readable

@WhiteSte WhiteSte changed the title Add a new readme section Refactor the readme file Jan 20, 2024
@pomadchin pomadchin added the docs label Jan 21, 2024
Copy link
Collaborator

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🚀, I left a couple of comments though to response / address.

(comments can be hidden under cut, easy to miss them)

image

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@WhiteSte
Copy link
Contributor Author

I think i solved almost all of them except for one

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 47 to 48
"io.pdal" %% "pdal-scala" % "<latest version>", // scala core library
"io.pdal" % "pdal-native" % "<latest version>" // jni bindings
"io.pdal" %% "pdal-scala" % "<latest version>", // scala core library
"io.pdal" % "pdal-native" % "<latest version>" // jni bindings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also affects the preview.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pomadchin
Copy link
Collaborator

Thx for working on the docs to make them more readable; really appreciate it! Sorry that I'm leaving up a bunch of comments every time.

@WhiteSte
Copy link
Contributor Author

Thx for working on the docs to make them more readable; really appreciate it! Sorry that I'm leaving up a bunch of comments every time.

Do not worry! I will take care next hours or tomorrow!

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making this hard work! Only two more comments to go!

@WhiteSte
Copy link
Contributor Author

Done, hope i didn't missed any comment

Copy link
Collaborator

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks!

@pomadchin pomadchin merged commit 25dd25b into PDAL:main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants