Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gdal_fwd.hpp when available for forward declarations #4608

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

hobu
Copy link
Member

@hobu hobu commented Jan 8, 2025

Addresses #4607

@hobu hobu added the bug label Jan 8, 2025
@hobu hobu added this to the 2.9.0 milestone Jan 8, 2025
@hobu hobu linked an issue Jan 8, 2025 that may be closed by this pull request
pdal/Geometry.hpp Outdated Show resolved Hide resolved
nalizing based on GDAL_COMPUTE_VERSION
@hobu hobu changed the title take advantage of gdal_fwd.hpp when available in GDAL 3.11+ Use gdal_fwd.hpp when available for forward declarations Jan 9, 2025
@abellgithub
Copy link
Contributor

Looks fine. I might check around to see if we're doing that same thing in other places -- it wouldn't surprise me.

@hobu hobu merged commit 80b977d into master Jan 10, 2025
22 of 23 checks passed
@hobu hobu deleted the issue-4607 branch January 10, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward OGR type declarations are fragile
2 participants