CI/AppImage: Add I_WANT_A_BROKEN_WAYLAND_UI environment variable #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
changed the title
Mrlinkwii
approved these changes
Oct 29, 2023
kamfretoz
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Slightly better version of #10179 which enables users to set an environment variable to force the use of Wayland if they want a rubbish, broken experience.
The way I had to do this was utterly disgusting, but LinuxDeploy doesn't let you add your own apprun-hooks, so we have to inject them in after the fact. Hopefully it won't break with some future LinuxDeploy update........
This'll probably have to stay around for years at least, because of the fundamental design flaws in the WL protocol, and if anything gets fixed, GNOME doesn't adopt it, so it's pointless. Guess we could check
XDG_SESSION_TYPE, but as it stands, WL on KWin is broken too.tldr, set
I_WANT_A_BROKEN_WAYLAND_UI=YES ./PCSX2.AppImage(or any other value) if you want pain and suffering, and don't complain.Rationale behind Changes
Giving users the choice.
Suggested Testing Steps
Test new option, make sure X11 gets used with it off.