pcre2test: really allow using libedit when enabled #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenas
changed the title
When `./configure --enable-pcre2test-libedit` is used in FreeBSD, the resulting test will succeed but won't set the necessary flag to distinguish between libedit and readline header files, therefore using readline's at built time (if installed) Consolidate all header tests into one and use instead the corresponding autogenerated defines to check for each possibility.
Using cmake to configure and enable linking pcre2test with libedit, could result in a broken build, because the header used was instead pointing to readline. In cases were the build will succeed (because both libraries were available), it would likely show warnings, because several history functions were being used without declarations, since readline requires including "history.h" for those. Additionally, since PCRE2_SUPPORT_READLINE is ON by default (unlike configure), turning PCRE2_SUPPORT_LIBEDIT=ON, would require setting that other option to OFF explicitly (even if readline wasn't available) or the setup would abort. Lastly, in systems with no default sysroot (ex: macOS), the use of absolute paths for searching for libedit's readline.h could fail so use instead relative PATH_SUFFIXES.
When asked to enable libedit in a system that ALSO has readline, the headers of the former would be found and used by the earlier. While that would mostly work, some functions will be missing definitions (which is forbidden in C99), so instead abort the configuration and let the user provide for them.
|
I don't really know much about Autotools, still less about CMake; these patches work for me so I have done the merge. Thanks for working in these areas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series fixes several issues found while testing PCRE2 in FreeBSD
The first one does the minimun possible change to expand the current
approach and could be simpified further, but those changes had been
punted for now, except for the one that is proposed in the last patch.
The second patch fixes the building issue for FreeBSD and is therefore
the more extensive, but the problem addressed is also affecting other
platforms, and also the configuration with autotools.
The last patch is the one with the highest potential for regressions, as
it would prevent building in systems that had libedit masquerading as
readline (ex: macOS) AND where the option to use libedit was requested
but in those cases enabling readline (which is the default with cmake)
instead works as expected, since in order to masquerade one library
with the other links for the header files and aliases for the library need
to be provided.