fix building on ancient compilers #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio older than 2013, fails to build with JIT enabled, because it is unable to parse non C89 compatible syntax, with mixed declarations and code. While most recent compilers wouldn't even report this as a warning since it is valid C99, it could be also made visible by adding to gcc/clang the -Wdeclaration-after-statement flag at build time. Move the code below the affected definitions.
Since d5a61ee (Patch to detect (and ignore) symlink loops in pcre2grep., 2021-08-28), code will fail to build in a strict C89 compiler. Reformat slightly to make it C89 compatible again.
|
I am ok with the jit changes. @PhilipHazel I would recommend to landing patches with "squash and merge", maybe we could disable the other options in the project settings. Merge commits make things difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly motivated by the building failures reported in #30.
The default target SDK for Visual Studio 2012 (AKA 11) seems to be Windows 7, which has been EOL already, but the compiler is still supported until beginning of next year, so probably worth fixing.
That version and the previous one (Visual Studio 10 2010) provide a working stdint.h that could be used as a fallback for the inttypes.h that the code requires.
The oldest compiler available in AppVeyor is Visual Studio 2008 (AKA 9) which probably target something even older than doesn't even provide a usable stdint.h, but will build fine with the suggested fallback.
The second patch is obviously not affecting Windows, but would probably trigger warnings in really old and still supported Linux as well that still have a compiler that default to the Gnu89 standard (ex: CentOS 7)