Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a regression in test4 and test7 where the first character of the set was unassigned and no longer qualifies for R bidi as shown by:
Had to revert several of the updates to
DerivedBidiClass.txt
that came with the released files.The gist of it is that (as described in the comments in that file) the new release relies in setting defaults for several characters that are not identified and that were marked in the previous release as "reserved".
The way the defaults are defined uses a comment that starts with "@missing:" and that we should IMHO parse and add to our lookup logic, but doing so has been punted for now.