Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Unicode 15 #200

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Jan 31, 2023

To avoid a regression in test4 and test7 where the first character of the set was unassigned and no longer qualifies for R bidi as shown by:

$ ./ucptest -s 590 5c6 200f 10805                                                                                                                   
U+0590 L   Control: Unassigned, unknown, Other, >֐<
U+05C6 R   Punctuation: Other punctuation, hebrew, Other, [alphabetic, caseignorable, extender, graphemebase, idcontinue, idstart, xidcontinue, xidstart], >׆<
U+200F R   Control: Format, common, Control, [dash, defaultignorablecodepoint, deprecated, emojipresentation, joincontrol, lowercase, patternwhitespace, radical, regionalindicator, softdotted, xidcontinue, xidstart], >‏<
U+10805 R   Letter: Other letter, cypriot, Other, [alphabetic, diacritic, graphemebase, idcontinue, xidcontinue], >𐠅<

Had to revert several of the updates to DerivedBidiClass.txt that came with the released files.

The gist of it is that (as described in the comments in that file) the new release relies in setting defaults for several characters that are not identified and that were marked in the previous release as "reserved".

The way the defaults are defined uses a comment that starts with "@missing:" and that we should IMHO parse and add to our lookup logic, but doing so has been punted for now.

@carenas carenas marked this pull request as draft January 31, 2023 03:27
Reverting several reserved characters that were removed from the
previous release, and that are only referencing as "@missing@ in
DerivedBidiClass.txt
@carenas carenas marked this pull request as ready for review January 31, 2023 04:59
@PhilipHazel PhilipHazel merged commit 40626f0 into PCRE2Project:master Feb 1, 2023
@carenas carenas deleted the unicode15 branch February 1, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants