Tried to fix issue #173 (using pcre2posix.h in MariaDB) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…totypes 4 functions prototypes were missing PCRE2_CALL_CONVENTION in src/pcre2posix.h All functions prototypes returning pointers had out of place PCRE2_CALL_CONVENTION in src/pcre2.h.* These produced errors when building for Windows with #define PCRE2_CALL_CONVENTION __stdcall. Tests after changes (Debug and Release configs): All OK.
cbouc
changed the title
carenas
suggested changes
Dec 8, 2022
| #ifndef PCRE2_CALL_CONVENTION | ||
| #define PCRE2_CALL_CONVENTION | ||
| #endif | ||
|
|
There was a problem hiding this comment.
the equivalent code should be then removed from pcre2posix.c
|
Unfortunately, this issue was not caught by the tests because pcre2test includes both pcre2.h and pcre2posix.h. I will do two things: I will move the default definition (and its comment) from pcre2posix.c to pcre2posix.h and I will write a little test program that just includes pcre2posix.h (without pcre2.h) and add this test to the test suite. |
|
@PhilipHazel Thanks! Once a test is added, could you consider a new release for this please? Otherwise all distributors of pcre2 are likely to have to hit the problem and then backport the fix after hopefully stumbling upon the bug I filed. |
|
Fixed by 16802f39. I will put out a new release fairly soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#173 Added default (empty) definition for PCRE2_CALL_CONVENTION in prec2posix.h just like that in prec2.h