Missing/misplaced PCRE2_CALL_CONVENTION macros in functions prototypes #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…totypes 4 functions prototypes were missing PCRE2_CALL_CONVENTION in src/pcre2posix.h All functions prototypes returning pointers had out of place PCRE2_CALL_CONVENTION in src/pcre2.h.* These produced errors when building for Windows with #define PCRE2_CALL_CONVENTION __stdcall. Tests after changes (Debug and Release configs): All OK.
|
Thanks for noticing and fixing this. |
PhilipHazel
added a commit
that referenced
this pull request
Aug 10, 2022
|
A drop in the ocean. Still, could be useful to someone else, and at the
very least, will be useful to me as I won’t have to remember and
reintroduce these fixes in future versions of PCRE2. I don’t think I will
do other pull request except if I find a crash and succeed to debug it.
Thank you for your work on PCRE2 !
*De :* Philip Hazel ***@***.***>
*Envoyé :* mercredi 10 août 2022 17:24
*À :* PCRE2Project/pcre2 ***@***.***>
*Cc :* cbouc ***@***.***>; Author ***@***.***>
*Objet :* Re: [PCRE2Project/pcre2] Missing/misplaced PCRE2_CALL_CONVENTION
macros in functions prototypes (PR #139)
Thanks for noticing and fixing this.
—
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKVPFU64GJ4TOPLYW3JHIDVYPCRPANCNFSM56DX4VSQ>
.
You are receiving this because you authored the thread.[image: Image
supprimée par l'expéditeur.]Message ID: <PCRE2Project/pcre2/pull/139/
***@***.***>
|
|
I think this may break consumers of pcre2: #173. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 functions prototypes were missing PCRE2_CALL_CONVENTION in src/pcre2posix.h
All functions prototypes returning pointers had out of place PCRE2_CALL_CONVENTION in src/pcre2.h.*
These produced errors when building for Windows with #define PCRE2_CALL_CONVENTION __stdcall.
Tests after changes (Debug and Release configs): All OK.