-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of old C89 standard #163
Comments
Declarations in "for" statements are in C99, so have been standardized for over 20 years. I am happy to move to C99, unless there are very strong objections. |
OK, I see. No objections. :-) |
carenas
added a commit
to carenas/pcre2
that referenced
this issue
Jan 15, 2023
Recent code uses C99 syntax (as reported in PCRE2Project#163, and therefore it will fail to build unless C99 (or higher) support is required by the compiler (gcc >= 5 does it by default). For those unfortunate to need an older compiler that does require a flag to enable that, make sure that both autoconf and cmake make it explicit. While testing the change with the ancient autoconf version listed as a prerequisite, noticed that the LT_INIT syntax introduced with 91485e5 (Update configure.ac for latest version of autoconf., 2021-02-02), was not supported, so update the autoconf minimum as well.
PhilipHazel
pushed a commit
that referenced
this issue
Jan 19, 2023
Recent code uses C99 syntax (as reported in #163, and therefore it will fail to build unless C99 (or higher) support is required by the compiler (gcc >= 5 does it by default). For those unfortunate to need an older compiler that does require a flag to enable that, make sure that both autoconf and cmake make it explicit. While testing the change with the ancient autoconf version listed as a prerequisite, noticed that the LT_INIT syntax introduced with 91485e5 (Update configure.ac for latest version of autoconf., 2021-02-02), was not supported, so update the autoconf minimum as well.
mdounin
added a commit
to freenginx/nginx
that referenced
this issue
Aug 12, 2024
Note that PCRE2 10.40 and newer versions require C99 support, as it now uses "for (int i = 0; ...)" constructs[1], and thus cannot be compiled with MSVC 2010 and older versions anymore. [1] PCRE2Project/pcre2#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure if support of old C89 standard has been cancelled but if this is not that case, the last release has introduced some small violations in modules
pcre2_compile.c
andpcre2_script_run.c
. Examples:Please consider to change it. Or feel free to close it without any actions if C89 violations are not an issue any more.
The text was updated successfully, but these errors were encountered: