Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot set property 'playerName' of undefined #51

Closed
Stannnnn opened this issue Apr 26, 2020 · 4 comments
Closed

TypeError: Cannot set property 'playerName' of undefined #51

Stannnnn opened this issue Apr 26, 2020 · 4 comments

Comments

@Stannnnn
Copy link
Contributor

TypeError: Cannot set property 'playerName' of undefined
at /node/classic-chat-bot-node/node_modules/w3gjs/src/W3GReplay.ts:108:61

The replay: https://tft.w3replayers.com/replays/download.php?id=29177

@PBug90
Copy link
Owner

PBug90 commented Apr 26, 2020

Looks like that replay has one player missing in the GameMetaDataReforged playerList, while the player exists in extraPlayerList. The player's nickname is banani#21111. This is odd and was not observed before.

I cannot even get the replay to show up in the actual game. Do you have any more information about this replay?

A possible workaround would be to ignore the ghost player record.

@Stannnnn
Copy link
Contributor Author

Its a custom game: Banjoball, I've seen it parse successfully before although the latest replays seem to throw this error. So if its a specific player that's causing it then that makes sense.

The map: https://www.dropbox.com/s/ioyivpyik1eivla/Banjoball%20v1.22C1%20%5BPROT%5D.w3x?dl=0

Can't seem to get the replay to show up in the actual game either.. Then again none of my replays are..

Guess ignoring the ghost player record sounds good if the rest of the parser doesn't depend on it.

PBug90 added a commit that referenced this issue Apr 28, 2020
…ist #51 (#52)

* fix: ignore reforged extra player if not existant in vanilla player list #51

* cicd: remove node version 9 build pipeline

* chore: dependency updates
@PBug90
Copy link
Owner

PBug90 commented Apr 28, 2020

Fixed in 1.7.1.

@PBug90
Copy link
Owner

PBug90 commented Apr 30, 2020

Closing this issue for now. Feel free to reopen if error occurs again.

@PBug90 PBug90 closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants