PAYOSWXP-158: Add PayPal v2 payment methods #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momocode-de
force-pushed
the
PAYOSWXP-158-PayPal-v2
branch
from
d2ca6d5 to
b70dc4e
Compare
rommelfreddy
requested changes
Oct 24, 2024
src/Components/GenericExpressCheckout/CustomerRegistrationUtil.php
Outdated
Show resolved
Hide resolved
tests/Components/GenericExpressCheckout/CustomerRegistrationUtilTest.php
Show resolved
Hide resolved
rommelfreddy
requested changes
Nov 23, 2024
src/Components/GenericExpressCheckout/CustomerRegistrationUtil.php
Outdated
Show resolved
Hide resolved
| $customerData = new RequestDataBag([ | ||
| 'guest' => true, | ||
| 'salutationId' => $salutationId, | ||
| 'email' => $response['addpaydata']['email'], | ||
| 'firstName' => $this->extractBillingData($response, 'firstname'), | ||
| 'lastName' => $this->extractBillingData($response, 'lastname'), | ||
| 'firstName' => $billingAddress['firstName'], /** @phpstan-ignore offsetAccess.notFound */ |
There was a problem hiding this comment.
yes, i unterstand, but if it would be still great, if we can get rid of an ignore.
as alternative: use the array_filter only for the parameter of method hasAddressRequiredData, or within the method itself - then you should not get an phpstan error.
src/Components/GenericExpressCheckout/CustomerRegistrationUtil.php
Outdated
Show resolved
Hide resolved
src/Resources/app/storefront/src/paypal-v2/payone-payment.paypal-v2.js
Outdated
Show resolved
Hide resolved
momocode-de
force-pushed
the
PAYOSWXP-158-PayPal-v2
branch
from
0e5efea to
350de26
Compare
rommelfreddy
force-pushed
the
PAYOSWXP-158-PayPal-v2
branch
from
59a950f to
42d3c03
Compare
rommelfreddy
requested changes
Dec 2, 2024
src/Resources/app/storefront/src/paypal-v2/payone-payment.paypal-v2.js
Outdated
Show resolved
Hide resolved
rommelfreddy
requested changes
Dec 2, 2024
rommelfreddy
approved these changes
Dec 11, 2024
rommelfreddy
approved these changes
Dec 11, 2024
rommelfreddy
requested changes
Dec 11, 2024
momocode-de
force-pushed
the
PAYOSWXP-158-PayPal-v2
branch
from
b8b7746 to
b4cada3
Compare
…stinguishableName' via subscriber
momocode-de
force-pushed
the
PAYOSWXP-158-PayPal-v2
branch
from
b4cada3 to
51fdf92
Compare
rommelfreddy
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.