Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump checkstyle to 10.18.2 #2077

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,11 @@ private ConverterUtils() {
* Returns the {@link RpcDefinition} from the given {@link EffectiveModelContext} and given {@link QName}.
* The {@link QName} of a rpc can be constructed via
*
* <p>
* {@code
* <p>{@code
* QName.create("http://netconfcentral.org/ns/toaster", "2009-11-20", "make-toast");
* } , where {@code "make-toast"} is the name of the RPC given in the yang model.
*
* <p>
* If the given RPC was found in the {@link EffectiveModelContext} the {@link RpcDefinition} will be returned
* <p>If the given RPC was found in the {@link EffectiveModelContext} the {@link RpcDefinition} will be returned
*
* @param effectiveModelContext the effective model context used for the RPC resolution
* @param rpcQName {@link QName} of the RPC
Expand Down Expand Up @@ -175,8 +173,7 @@ public static XmlElement rpcAsOutput(final XmlElement inputXmlElement, final Str
/**
* Finds the {@link DataSchemaContext} for the given {@link QName} in {@link EffectiveModelContext}.
*
* <p>
* Search is performed only on first level nodes of the modules, for recursive search,
* <p>Search is performed only on first level nodes of the modules, for recursive search,
* the {@link YangInstanceIdentifier} is needed, thus consider using
* {@link ConverterUtils#getSchemaNode(EffectiveModelContext, YangInstanceIdentifier)}.
*
Expand Down Expand Up @@ -206,8 +203,7 @@ public static XmlElement rpcAsOutput(final XmlElement inputXmlElement, final Str
* Finds the {@link DataSchemaContext} for the given namespace, revision and local name
* in {@link EffectiveModelContext}.
*
* <p>
* Search is performed only on first level nodes of the modules, for recursive search,
* <p>Search is performed only on first level nodes of the modules, for recursive search,
* the {@link YangInstanceIdentifier} is needed, thus consider using
* {@link ConverterUtils#getSchemaNode(EffectiveModelContext, YangInstanceIdentifier)}.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,9 @@ public class JsonNodeConverter implements NodeConverter {
* This constructor will create an instance of {@link JsonNodeConverter} with the given
* {@link EffectiveModelContext}.
*
* <p>
* The effective model context will be used for proper RPC and Node resolution.
* <p>The effective model context will be used for proper RPC and Node resolution.
*
* <p>
* The {@code JSONCodecFactorySupplier.DRAFT_LHOTKA_NETMOD_YANG_JSON_02} will be used for JSON
* <p>The {@code JSONCodecFactorySupplier.DRAFT_LHOTKA_NETMOD_YANG_JSON_02} will be used for JSON
* serialization/deserialization of data.
*
* @param effectiveModelContext initial effective model context
Expand All @@ -69,11 +67,9 @@ public JsonNodeConverter(final EffectiveModelContext effectiveModelContext) {
* This constructor will create an instance of {@link JsonNodeConverter} with the given
* {@link EffectiveModelContext} and customizable {@link JSONCodecFactorySupplier}.
*
* <p>
* The effective model context will be used for proper RPC and Node resolution.
* <p>The effective model context will be used for proper RPC and Node resolution.
*
* <p>
* The {@code JSONCodecFactorySupplier} instance will be used for JSON serialization/deserialization of data.
* <p>The {@code JSONCodecFactorySupplier} instance will be used for JSON serialization/deserialization of data.
*
* @param effectiveModelContext initial effective model context
* @param jsonCodecFactorySupplier JSON codec factory supplier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ public Writer serializeRpc(final Inference inference, final NormalizedNode norma
/**
* Deserializes a given XML input data into {@link NormalizedNode}.
*
* <p>
* In the case of deserializing multiple top level list entries, entries are expected to be wrapped in
* <p>In the case of deserializing multiple top level list entries, entries are expected to be wrapped in
* {@code <data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">}.
*
* @param inference {@link Inference} pointing to a node we are trying to deserialize
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
* {@link LightyController} shutdown process. This configuration initializes all core lighty.io services as spring
* beans.
*
* <p>
* Example:
* <p>Example:
* <pre>
* &#64;Configuration
* public class LightyConfiguration extends LightyCoreSprigConfiguration {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
* {@link AbstractLightyModule#startBlocking()} and
* {@link AbstractLightyModule#shutdown()} methods.
*
* <p>
* <b>Example usage:</b>
* <p><b>Example usage:</b>
* <pre>
* <code>
* public class MyLightyModule extends AbstractLightyModule {
Expand Down Expand Up @@ -211,8 +210,7 @@ public final boolean shutdown(final long duration, final TimeUnit unit) {
/**
* Invoke blocking shutdown after blocking start.
*
* <p>
* Release CountDownLatch locking this thread and shutdown.
* <p>Release CountDownLatch locking this thread and shutdown.
* @param duration duration to wait for shutdown to complete
* @param unit {@link TimeUnit} of {@code duration}
* @return {@code boolean} indicating shutdown sucess
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,9 @@ public static void importConfigDataFile(final InputStream inputStream,
/**
* Writes/merges input stream containing serialized normalized node data into config datastore.
*
* <p>
* Node is written at root node, that means only top level nodes are supported.
* <p>Node is written at root node, that means only top level nodes are supported.
*
* <p>
* In the case of importing XML file, node needs to be wrapped in
* <p>In the case of importing XML file, node needs to be wrapped in
* {@code <data xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">} element.
*
* @param inputStream stream of serialized node to deserialize
Expand Down
2 changes: 1 addition & 1 deletion lighty-core/lighty-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<!-- This should match the dependency management on com.puppycrawl.tools:checkstyle above -->
<version>10.17.0</version>
<version>10.18.2</version>
</dependency>
<dependency>
<groupId>com.github.sevntu-checkstyle</groupId>
Expand Down
Loading