Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes fit_transform_with_metadata() API, refactors ProjectorModel. #1209

Merged
merged 0 commits into from
Aug 1, 2023
Merged

Removes fit_transform_with_metadata() API, refactors ProjectorModel. #1209

merged 0 commits into from
Aug 1, 2023

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jul 31, 2023 •
edited
Loading

Removes fit_transform_with_metadata() API, refactors ProjectorModel.

  • Removes fit_transform_with_metadata() API from LIT.
  • Moves ProjectorModel from components/projector.py to api/model.py to make it accessible to lib/ and components/ modules.
  • Updates components/projector.py type annotations to reference lit_nlp.api.model.ProjectorModel.
  • Refactors PCAModel to inherit from lit_nlp.api.model.ProjectorModel.
  • Refactors UmapModel to inherit from lit_nlp.api.model.ProjectorModel.
  • Refactors CachingModelWrapper.fit_transform() to check inheritance from ProjectorModel before calling wrapped.fit_transform().
  • Removes fit_transform() API from Model base class.

@copybara-service copybara-service bot force-pushed the test_552549294 branch 3 times, most recently from cf530ca to 5471644 Compare August 1, 2023 17:04
@copybara-service copybara-service bot closed this Aug 1, 2023
@copybara-service copybara-service bot merged commit e30e59a into dev Aug 1, 2023
@copybara-service copybara-service bot deleted the test_552549294 branch August 1, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants