-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for x86_64 #74
Conversation
As for x86_64, the first 6 arguments are passed in registers RDI, RSI, RDX, RCX, R8, R9. So I think |
http://androidxref.com/7.0.0_r1/xref/art/runtime/arch/x86_64/quick_entrypoints_x86_64.S#455:
|
The code follows the same structure of x86. The only tricky detail is that the method pointer must be in `rdi`, as specified on http://androidxref.com/7.0.0_r1/xref/art/runtime/arch/x86_64/quick_entrypoints_x86_64.S#455.
That worked! |
A quick update on the tests: x86_64 doesn't work on API versions 21, 22, 23 and 27. I'm guessing 21-23 might be caused by #61 |
It's weird on API 27 since my previous demo works but the unit test fails. The debugger shows it crashes when updating the cached method. Needs to take a deeper look at it. |
I think maybe we could create a new issue to track the problem. |
The code follows the same structure of x86, but it doesn't work. Any ideas?
This is a follow-up for #69