Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor compilation fixes with gcc 11.3 #177

Merged
merged 4 commits into from
Jun 4, 2023

Conversation

r1viollet
Copy link

Requirements for Adding, Changing, Fixing or Removing a Feature

Fill out the template below. Any pull request that does not include enough
information to be reviewed in a timely manner may be closed at the maintainers'
discretion.

Description of the Change

Reduce scope of alloc variable

Alternate Designs

N/A

Regressions

N/A

Verification Process

r1viollet added 2 commits May 17, 2023 09:52
The d_name variable is a table of 256. It can not be null.
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (369b825) 69.96% compared to head (4ebbe10) 70.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #177      +/-   ##
==========================================
+ Coverage   69.96%   70.11%   +0.14%     
==========================================
  Files          25       25              
  Lines        2474     2473       -1     
  Branches      730      730              
==========================================
+ Hits         1731     1734       +3     
+ Misses        412      410       -2     
+ Partials      331      329       -2     
Impacted Files Coverage Δ
src/linux/addr2line.h 52.38% <100.00%> (-0.75%) ⬇️
src/py_proc_list.c 75.60% <100.00%> (+0.81%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@P403n1x87 P403n1x87 changed the base branch from master to devel May 30, 2023 12:43
@P403n1x87 P403n1x87 changed the title Minor compilation fix with gcc 11.3 chore: minor compilation fixes with gcc 11.3 May 30, 2023
@P403n1x87 P403n1x87 merged commit f53679e into P403n1x87:devel Jun 4, 2023
@P403n1x87
Copy link
Owner

Thanks 🙏

P403n1x87 added a commit that referenced this pull request Jun 28, 2023
chore: minor compilation fixes with gcc 11.3
P403n1x87 added a commit that referenced this pull request Jun 28, 2023
chore: minor compilation fixes with gcc 11.3 [cherry-pick of #177 to master]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants