fix: 🐛 Introduced bug in Compression Upgrade controlled part of inven…

…tory and its implementation of extractItem method of IItemHandler by not capping the extracted stack at maxStackSize as defined in the API definition. This is a roundabout way of fixing a dupe bug in Refined Storage they are not fixing. Hopefully this doesn't break something else, but other mods are not following this part of API definition and there don't seem to be reports regarding that so fingers crossed.

gradle.properties

@@ -3,7 +3,7 @@ org.gradle.daemon=false
 
 mod_id=sophisticatedstorage
 mod_group_id=sophisticatedstorage
-mod_version=1.1.4
+mod_version=1.1.5
 sonar_project_key=sophisticatedstorage:SophisticatedStorage
 github_package_url=https://maven.pkg.github.com/P3pp3rF1y/SophisticatedStorage
 

src/main/java/net/p3pp3rf1y/sophisticatedstorage/upgrades/compression/CompressionInventoryPart.java

@@ -286,7 +286,8 @@ private int getStackLimit(SlotDefinition slotDefinition) {
 
 	@Override
 	public ItemStack extractItem(int slot, int amount, boolean simulate) {
-		return extractItem(slot, amount, simulate, ItemStack::getMaxStackSize);
+		//return extractItem(slot, amount, simulate, ItemStack::getMaxStackSize);
+		return extractItem(slot, amount, simulate, s -> Integer.MAX_VALUE); //!!! DON'T MERGE THIS TO ANY OTHER VERSION This limitation to max int is a bug introduced so that RS doesn't duplicate !!!
 	}
 
 	private ItemStack extractItem(int slot, int amount, boolean simulate, ToIntFunction<ItemStack> getLimit) {

src/test/java/net/p3pp3rf1y/sophisticatedstorage/upgrades/compression/CompressionInventoryPartTest.java

@@ -845,7 +845,8 @@ private static List<ExtractingFromFullyFilledSlotsProperlyCalculatesCountsParams
 						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 256)),
 						256,
 						ImmutablePair.of(1, 256),
-						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 2496))
+						/*Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 2496)) !!! THIS GOT BROKEN AS PART OF RS DUPE "FIX" */
+						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 2304))
 				),
 				new ExtractingFromFullyFilledSlotsProperlyCalculatesCountsParams(
 						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 256)),
@@ -863,7 +864,8 @@ private static List<ExtractingFromFullyFilledSlotsProperlyCalculatesCountsParams
 						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 256), 2, new ItemStack(Items.IRON_NUGGET, 256)),
 						256,
 						ImmutablePair.of(2, 256 + 10 * 9),
-						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 2560), 2, new ItemStack(Items.IRON_NUGGET, 23232)) // the extract gets maxed to 64
+						/*Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 2560), 2, new ItemStack(Items.IRON_NUGGET, 23232)) !!! THIS GOT BROKEN AS PART OF RS DUPE "FIX" // the extract gets maxed to 64*/
+						Map.of(0, new ItemStack(Items.IRON_BLOCK, 256), 1, new ItemStack(Items.IRON_INGOT, 2550), 2, new ItemStack(Items.IRON_NUGGET, 22950)) // the extract gets maxed to 64
 				)
 		);
 	}