fix: 🐛 Fixed handling of fluids that were removed from modpack in tan…

…k upgrade so that it properly gets set as empty and doesn't crash in some cases
P3pp3rF1y · Nov 18, 2024 · 0d1f1cd · 0d1f1cd
1 parent dd941fc
commit 0d1f1cd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -13,7 +13,7 @@ loader_version_range=[4,)
 mod_id=sophisticatedbackpacks
 mod_name=Sophisticated Backpacks
 mod_license=GNU General Public License v3.0
-mod_version=3.20.23
+mod_version=3.20.24
 mod_group_id=sophisticatedbackpacks
 mod_authors=P3pp3rF1y, Ridanisaurus
 mod_description=Fancy and functional backpacks.

diff --git a/src/main/java/net/p3pp3rf1y/sophisticatedbackpacks/client/render/BackpackDynamicModel.java b/src/main/java/net/p3pp3rf1y/sophisticatedbackpacks/client/render/BackpackDynamicModel.java
@@ -211,7 +211,7 @@ private void addLeftSide(@Nullable BlockState state, @Nullable Direction side, R
 		}
 
 		private void addFluid(List<BakedQuad> ret, FluidStack fluidStack, float ratio, double xMin) {
-			if (Mth.equal(ratio, 0.0f)) {
+			if (fluidStack == FluidStack.EMPTY || Mth.equal(ratio, 0.0f)) {
 				return;
 			}
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     		private void addFluid(List<BakedQuad> ret, FluidStack fluidStack, float ratio, double xMin) {
-    			if (Mth.equal(ratio, 0.0f)) {
+    			if (fluidStack == FluidStack.EMPTY || Mth.equal(ratio, 0.0f)) {
     				return;
     			}
@@ Expand Down @@