Fix duplicate content updates run on channel switch (FreeTubeApp#3764)

* Revert "Bump prettier from 2.8.8 to 3.0.0 (FreeTubeApp#3758)" This reverts commit f77ae6d. * ! Fix duplicate content updates run on channel switch
OwenTruong · Jul 13, 2023 · 930184d · 930184d
1 parent 0d10fac
commit 930184d
Showing 1 changed file with 24 additions and 3 deletions.
diff --git a/src/renderer/views/Channel/Channel.js b/src/renderer/views/Channel/Channel.js
@@ -104,7 +104,9 @@ export default defineComponent({
       playlistSelectValues: [
         'newest',
         'last'
-      ]
+      ],
+
+      autoRefreshOnSortByChangeEnabled: false,
     }
   },
   computed: {
@@ -257,6 +259,9 @@ export default defineComponent({
         return
       }
 
+      // Disable auto refresh on sort value change during state reset
+      this.autoRefreshOnSortByChangeEnabled = false
+
       this.id = this.$route.params.id
       this.searchPage = 2
       this.relatedChannels = []
@@ -296,14 +301,20 @@ export default defineComponent({
       this.showShareMenu = true
       this.errorMessage = ''
 
+      // Re-enable auto refresh on sort value change AFTER update done
       if (!process.env.IS_ELECTRON || this.backendPreference === 'invidious') {
         this.getChannelInfoInvidious()
+        this.autoRefreshOnSortByChangeEnabled = true
       } else {
-        this.getChannelLocal()
+        this.getChannelLocal().finally(() => {
+          this.autoRefreshOnSortByChangeEnabled = true
+        })
       }
     },
 
     videoSortBy () {
+      if (!this.autoRefreshOnSortByChangeEnabled) { return }
+
       this.isElementListLoading = true
       this.latestVideos = []
       switch (this.apiUsed) {
@@ -319,6 +330,8 @@ export default defineComponent({
     },
 
     shortSortBy() {
+      if (!this.autoRefreshOnSortByChangeEnabled) { return }
+
       this.isElementListLoading = true
       this.latestShorts = []
       switch (this.apiUsed) {
@@ -334,6 +347,8 @@ export default defineComponent({
     },
 
     liveSortBy () {
+      if (!this.autoRefreshOnSortByChangeEnabled) { return }
+
       this.isElementListLoading = true
       this.latestLive = []
       switch (this.apiUsed) {
@@ -349,6 +364,8 @@ export default defineComponent({
     },
 
     playlistSortBy () {
+      if (!this.autoRefreshOnSortByChangeEnabled) { return }
+
       this.isElementListLoading = true
       this.latestPlaylists = []
       this.playlistContinuationData = null
@@ -382,10 +399,14 @@ export default defineComponent({
       return
     }
 
+    // Enable auto refresh on sort value change AFTER initial update done
     if (!process.env.IS_ELECTRON || this.backendPreference === 'invidious') {
       this.getChannelInfoInvidious()
+      this.autoRefreshOnSortByChangeEnabled = true
     } else {
-      this.getChannelLocal()
+      this.getChannelLocal().finally(() => {
+        this.autoRefreshOnSortByChangeEnabled = true
+      })
     }
   },
   methods: {