This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Fix addItem method in CraftInventory #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should take a look at https://github.com/OvercastNetwork/SportBukkit/blob/master/CraftBukkit/Reduce-ItemStack-copying.patch#L258 ,we don't want a new patch to fix an older one, just edit the older one instead |
cswhite2000
force-pushed
the
master
branch
2 times, most recently
from
776680e
to
dad6b95
Compare
|
I moved the fix to the Reduce-ItemStack-copying patch |
|
Did you run this thru the scripts? shouldn't it also edit the CB snapshot? |
|
I guess I forgot to run rake snapshot. It should be fixed now. |
|
And yes, I did run it through the scripts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CraftInventory class the firstEmpty method, called by addItem, wasn't working correctly. This caused the addItem method to only add items to stacks that already had the item. This fixes //wand not working in worldedit and /give not working in commandbook.