Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: macos bundle id contains underscore (_) #32

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: macos bundle id contains underscore (_) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '11.0'
# platform :ios, '12.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
6 changes: 3 additions & 3 deletions example/macos/Runner.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@
CURRENT_PROJECT_VERSION = 1;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet_connection_checker_plus_example.RunnerTests;
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet-connection-checker-plus-example.RunnerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Internet Connection Checker Plus Example.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Internet Connection Checker Plus Example";
Expand All @@ -494,7 +494,7 @@
CURRENT_PROJECT_VERSION = 1;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet_connection_checker_plus_example.RunnerTests;
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet-connection-checker-plus-example.RunnerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Internet Connection Checker Plus Example.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Internet Connection Checker Plus Example";
Expand All @@ -509,7 +509,7 @@
CURRENT_PROJECT_VERSION = 1;
GENERATE_INFOPLIST_FILE = YES;
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet_connection_checker_plus_example.RunnerTests;
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet-connection-checker-plus-example.RunnerTests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/Internet Connection Checker Plus Example.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/Internet Connection Checker Plus Example";
Expand Down
2 changes: 1 addition & 1 deletion example/macos/Runner/Configs/AppInfo.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
PRODUCT_NAME = Internet Connection Checker Plus Example

// The application's bundle identifier
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet_connection_checker_plus_example
PRODUCT_BUNDLE_IDENTIFIER = rocks.outdatedguy.internet-connection-checker-plus-example

// The copyright displayed in application information
PRODUCT_COPYRIGHT = Copyright © 2023 OutdatedGuy. All rights reserved.
2 changes: 1 addition & 1 deletion example/package_rename_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ package_rename_config:

macos:
app_name: Internet Connection Checker Plus Example
package_name: rocks.outdatedguy.internet_connection_checker_plus_example
package_name: rocks.outdatedguy.internet-connection-checker-plus-example
copyright_notice: Copyright © 2023 OutdatedGuy. All rights reserved.

web:
Expand Down
Loading