Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mixpanel copy #616

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Feat/mixpanel copy #616

merged 10 commits into from
Dec 3, 2024

Conversation

zhouxl
Copy link
Collaborator

@zhouxl zhouxl commented Dec 2, 2024

Related Issue

[Event Tracking] Add mixpanel event tracking
#371

Summary of Changes

new future
https://app.gitbook.com/o/btnrCjBfFA1CijnAHf9d/s/uD5IIQEzBNOcwceEz9qr/

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Doc

Screenshots (if applicable)

# Conflicts:
#	FRW/Modules/EVM/ViewModel/EVMEnableViewModel.swift
#	FRW/Modules/Staking/StakeAmount/StakeAmountViewModel.swift
#	FRW/Modules/Wallet/CreateAccount/CreateProfileWaitingViewModel.swift
#	FRW/Services/Manager/TransactionManager.swift
#	FRW/Services/Network/FlowNetwork.swift
@zhouxl zhouxl requested review from lmcmz and jeden December 2, 2024 08:23
Copy link
Collaborator

@jeden jeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes

FRW/Modules/EVM/ViewModel/EVMEnableViewModel.swift Outdated Show resolved Hide resolved
FRW/Services/Track/EventTrack.swift Outdated Show resolved Hide resolved
@zhouxl zhouxl merged commit 86bdf99 into develop Dec 3, 2024
1 check passed
@zhouxl zhouxl deleted the feat/mixpanel-copy branch December 3, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants