Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix in app browser security issue #488

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

jeden
Copy link
Collaborator

@jeden jeden commented Nov 5, 2024

@jeden jeden requested review from zhouxl and lmcmz November 5, 2024 04:31
@lmcmz
Copy link
Member

lmcmz commented Nov 5, 2024

Nice work, we do have some other place also use the url.
Probably, we could change them all together. if it's possible.
https://github.com/search?q=repo%3AOutblock%2FFRW-iOS%20webVC%3F.webView.url&type=code

Copy link
Member

@lmcmz lmcmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other scenario, we don't have the example url yet.
Currently, this one is only for EVM authn

@jeden jeden requested a review from lmcmz November 5, 2024 22:09
@jeden
Copy link
Collaborator Author

jeden commented Nov 5, 2024

Nice work, we do have some other place also use the url. Probably, we could change them all together. if it's possible. https://github.com/search?q=repo%3AOutblock%2FFRW-iOS%20webVC%3F.webView.url&type=code

I think I covered all cases — however I couldn't test all of them as not sure how to trigger each individual case. Any suggestion, if you think it's needed?

@lmcmz
Copy link
Member

lmcmz commented Nov 5, 2024

I think it should be fine, it's a bit hard to simulate the snoof in all cause.
We just make sure if the normal flow is working, then it should be fine.

@lmcmz lmcmz merged commit 2b00b72 into develop Nov 5, 2024
1 check passed
@lmcmz lmcmz deleted the fts/485-browser-security-issue branch November 5, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants