RNMT-5885 - solve lumberjack dependency #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmfsotelo
requested review from
a team,
andredestro,
EiyuuZack,
Chuckytuh,
tiagoappereira,
sandrarodrigues76 and
usernuno
and removed request for
a team
EiyuuZack
approved these changes
Nov 28, 2022
usernuno
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For MABS to be able to successfully build this library we need to either have the use_frameworks! on the podfile OR have the cordova-ios issues apache/cordova-ios#659 and apache/cordova-ios#617 fixed.
We have the second option being tackled in this PR in the cordova-ios repo.
Template PR that glue this and the previously mentioned PR should be tackled afterwards
Impacts
References: RNMT-5885
Tests
The builds built in the past days have all been containing these changes (template version 12.4.0-dev.5 or 12.4.0-dev.6)
App Logs in Service Center here.