Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regrid for snakemake #414

Merged
merged 20 commits into from
Jun 20, 2024
Merged

fix regrid for snakemake #414

merged 20 commits into from
Jun 20, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Jun 17, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • write regrid weights in file with domain name

Does this PR introduce a breaking change?

no

Other information:

Previously, we would only do one regrid at the time. With snakemake, they can be done synchronously. This means we need the name of the domain in the name of the file, or different task try to write on the same file.

PVI: @oumoukal @aulemahal

@RondeauG
Copy link
Collaborator

Could you also include the fix to #411? The fix was given here: f12895a

Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once xclim v0.50 is available and fixes the tests.

@RondeauG
Copy link
Collaborator

Could you also add a <0.51 to xclim, to help with #399 and future breaking changes?

@juliettelavoie
Copy link
Contributor Author

I pinned xarray <2024.06.0. I think the failing tests in adjust were related to pydata/xarray#9138.

@juliettelavoie
Copy link
Contributor Author

@Zeitsperre do you have an idea what is the issue for py310-covervalls ?

@juliettelavoie
Copy link
Contributor Author

@Zeitsperre We managed to fix the issue in the coveralls tests by pinning h5py and netcdf4. Would still love your input if you know the cause of the problem!

@juliettelavoie juliettelavoie merged commit c12d5aa into main Jun 20, 2024
16 checks passed
@juliettelavoie juliettelavoie deleted the fix-regrid branch June 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regridding weights not properly reused Add <= pin on xclim
2 participants