Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unidecode (for anyascii), pandoc, poppler, and tbb #505

Merged
merged 2 commits into from
May 14, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented May 13, 2024

Overview

This PR addresses issues raised in #494

Changes:

  • Replaced unidecode (GPLv2) with anyascii (MIT)
  • Removed pandoc, poppler, and tbb from conda environment dependencies

Related Issue / Discussion

There are still some final issues with the licensing for cartopy which changed from LGPL to BSD-3-Clause in version 0.23. This update will force us to drop Python3.8. I'll address this in a new Pull Request.

@Zeitsperre Zeitsperre added the dependencies Pull requests that update a dependency file label May 13, 2024
@Zeitsperre Zeitsperre requested a review from huard May 13, 2024 21:34
@Zeitsperre Zeitsperre self-assigned this May 13, 2024
@Zeitsperre Zeitsperre changed the title remove unidecode, replace with anyascii Remove unidecode, pandoc, poppler, tbb, and upgrade Cartopy May 13, 2024
@Zeitsperre Zeitsperre changed the title Remove unidecode, pandoc, poppler, tbb, and upgrade Cartopy Remove unidecode (for anyascii), pandoc, poppler, and tbb May 13, 2024
@Zeitsperre Zeitsperre requested a review from tlvu May 13, 2024 21:49
Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are pandoc, poppler, and tbb being dropped also due to licensing issues or they are unused? The reason is not apparently clear to me.

@tlvu
Copy link
Contributor

tlvu commented May 14, 2024

I am guessing a matching dependencies cleanup PR will also be needed on conda packaging side?

@Zeitsperre
Copy link
Contributor Author

Are pandoc, poppler, and tbb being dropped also due to licensing issues or they are unused? The reason is not apparently clear to me.

As far as I can tell, these dependencies are not needed to run the library (in addition to being under GPL/copyleft licenses):

  • pandoc is needed to convert documentation to other formats (this can be done already in ReadTheDocs/sphinx directly)
  • tbb and poppler are never called in the code

The changes will eventually be ported to the conda-forge package as well!

@Zeitsperre Zeitsperre merged commit 8e69699 into main May 14, 2024
10 of 11 checks passed
@Zeitsperre Zeitsperre deleted the drop-unidecode branch May 14, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants