Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a docker-based testing suite #481

Merged
merged 19 commits into from
Jul 17, 2023
Merged

Add a docker-based testing suite #481

merged 19 commits into from
Jul 17, 2023

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Jul 10, 2023

Overview

Changes:

  • Added a workflow that uses a docker image to test RavenWPS
  • Modified Dockerfile to no longer emit warnings on build.
  • Standardized recipe with other project conventions.
  • Fixed a bug in the Makefile that was calling ifdef in make land and not within shell land

Related Issue / Discussion

Additional Information

Links to other issues or sources.

@Zeitsperre Zeitsperre added the enhancement New feature or request label Jul 10, 2023
@Zeitsperre Zeitsperre self-assigned this Jul 10, 2023
@Zeitsperre Zeitsperre requested a review from tlvu July 12, 2023 16:26
Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the corresponding Finch PR, awesome useful PR to test the docker image.

Just minor change requested for the Dockerfile.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@Zeitsperre Zeitsperre requested a review from tlvu July 12, 2023 19:38
Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just minor comments.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit 0d5a5ed into master Jul 17, 2023
@Zeitsperre Zeitsperre deleted the docker-actions branch July 17, 2023 13:29
Zeitsperre added a commit to bird-house/finch that referenced this pull request Jul 17, 2023
## Overview

Changes:

* Added a dockerfile testing workflow
* Updated metadata in docker image
* Explicitly support Python3.11
* Set an upper pin on Python (below v3.12)

## Related Issue / Discussion

Ouranosinc/raven#481
Zeitsperre added a commit that referenced this pull request Aug 17, 2023
## Overview

Changes:

* Added a workflow that uses a docker image to test RavenWPS
* Modified Dockerfile to no longer emit warnings on build.
* Standardized recipe with other project conventions.
* Fixed a bug in the Makefile that was calling `ifdef` in `make` land
and not within `shell` land
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants