-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a docker-based testing suite #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the corresponding Finch PR, awesome useful PR to test the docker image.
Just minor change requested for the Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just minor comments.
## Overview Changes: * Added a dockerfile testing workflow * Updated metadata in docker image * Explicitly support Python3.11 * Set an upper pin on Python (below v3.12) ## Related Issue / Discussion Ouranosinc/raven#481
## Overview Changes: * Added a workflow that uses a docker image to test RavenWPS * Modified Dockerfile to no longer emit warnings on build. * Standardized recipe with other project conventions. * Fixed a bug in the Makefile that was calling `ifdef` in `make` land and not within `shell` land
Overview
Changes:
ifdef
inmake
land and not withinshell
landRelated Issue / Discussion
Additional Information
Links to other issues or sources.