-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use RavenPy v0.8.1 and adjust documentation #439
Conversation
…atershed notebook, use mamba for docs-building, fail on warning, formatting
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
0102349
to
3e00a43
Compare
Running into an issue due to settings in ReadTheDocs. Relevant information here: readthedocs/readthedocs.org#9306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh they previously activate this Latest conda now not fast or use too much memory? Have to switch to mamba? |
Here is when that conda update is activated for Raven: readthedocs/readthedocs.org#5847 (comment) |
Ah! I forgot that was done on this repo/project. My bad!
I figured why not have more synonymous buildouts for all of our documentation. It's not absolutely necessary, but it can't hurt? |
Not hurt but I guess now you'll have to open an issue for RtD dev to disable that conda update flag for mamba to work. |
# Conflicts: # .readthedocs.yml # docs/source/notebooks/02_Extract_geographical_watershed_properties.ipynb # docs/source/notebooks/Extract_geographical_watershed_properties.ipynb
for more information, see https://pre-commit.ci
* Updated GitHub Workflows * Use latest Ubuntu images * Linting to use Python3.8 * Staged a Python3.10 build for testing purposes * Updated pre-commit hooks * Added pygrep-hooks, NBQA-hooks, yamlint, blackdoc, check-manifest, GitHub and RtD schema validation * Ran hooks over code base * Updated ReadTheDocs to make use of mamba dependency solver
## Summary of changes - Updated from RavenPy v0.7.8 to v0.8.1 - Dropped support for Python3.7 (same as in RavenPy) - Added `rioxarray` and `ipywidgets` to requirements (used explicitly in notebooks) - Removed a duplicated notebook (`Extract_geographical_watershed_properties.ipynb`) that was not in the existing documentation. - Set notebooks under docs/source/paper to be ignored. - Set ReadTheDocs to use `mambaforge` for installing dependencies (quicker/less memory intensive) - Set ReadTheDocs builds to "fail-on-warning" - Updated GitHub Workflows: * Use latest Ubuntu images * Linting to use Python3.8 * Staged a Python3.10 build for testing purposes * Updated pre-commit hooks: * Added pygrep-hooks, NBQA-hooks, yamlint, blackdoc, check-manifest, GitHub and RtD schema validation * Ran hooks over code base
Summary of changes
Updated from RavenPy v0.7.8 to v0.8.1
Dropped support for Python3.7 (same as in RavenPy)
Added
rioxarray
andipywidgets
to requirements (used explicitly in notebooks)Removed a duplicated notebook (
Extract_geographical_watershed_properties.ipynb
) that was not in the existing documentation.Set notebooks under docs/source/paper to be ignored.
Set ReadTheDocs to use
mambaforge
for installing dependencies (quicker/less memory intensive)Set ReadTheDocs builds to "fail-on-warning"
Updated GitHub Workflows:
GitHub and RtD schema validation