Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metadata_type.prefixes and data_type.prefixes in ServiceTHREDDS configuration to contain / character #634

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

mishaschwartz
Copy link
Collaborator

@mishaschwartz mishaschwartz commented Dec 9, 2024

Resolves #633

Also updates a broken docs link (unrelated to this PR but required to make CI tests run)

@github-actions github-actions bot added doc Documentation improvements or building problem tests Test execution or additional use cases labels Dec 9, 2024
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just minor comments to address.

docs/services.rst Outdated Show resolved Hide resolved
magpie/services.py Show resolved Hide resolved
magpie/services.py Outdated Show resolved Hide resolved
tests/test_services.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Just waiting for CI to validate.

@fmigneault fmigneault merged commit e77d8a9 into master Dec 12, 2024
18 checks passed
@fmigneault fmigneault deleted the thredds-prefix-path-fix branch December 12, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation improvements or building problem feature/service/THREDDS tests Test execution or additional use cases
Projects
None yet
2 participants