Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin setuptools version breaking build/install #260

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Mar 9, 2020

pin 'zope.interface>=4.7.0' minimal version (via zopefoundation/zope.interface#30) to fix missing 'Features' feature officially removed (via pypa/setuptools#65) and pin setuptools<46.0.0

references zopefoundation/zope.interface#184

…interface#30) to fix missing 'Features' feature officially removed (via pypa/setuptools#65) and pin setuptools<46.0.0
@fmigneault fmigneault requested a review from davidcaron March 9, 2020 22:02
@github-actions github-actions bot added the ci Something related to code tests, deployment and packaging label Mar 9, 2020
@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          90       90           
  Lines        7121     7121           
=======================================
  Hits         5065     5065           
  Misses       2056     2056

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18cfc3...3751e18. Read the comment docs.

@davidcaron
Copy link
Contributor

Try to pin just zope.interface>=4.7.2 and not setuptools, it looks like 4.7.2 was released 6 hours ago and fixes this issue. zopefoundation/zope.interface#150

@fmigneault
Copy link
Collaborator Author

Try to pin just zope.interface>=4.7.2 and not setuptools, it looks like 4.7.2 was released 6 hours ago and fixes this issue. zopefoundation/zope.interface#150

Yes this was just done as requested by me: zopefoundation/zope.interface#184
Fix didn't exist at the time.
Will apply it via zope instead.

@fmigneault fmigneault merged commit 3f2877c into master Mar 10, 2020
@fmigneault fmigneault deleted the setuptools-pin branch March 10, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Something related to code tests, deployment and packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants