Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting and improvements #176

Merged
merged 16 commits into from
Apr 15, 2019
Merged

formatting and improvements #176

merged 16 commits into from
Apr 15, 2019

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Apr 12, 2019

resolves #126
resolves #162
resolves #163
resolves #167
addresses #74 with multiple new tests

@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #176 into master will increase coverage by 1.09%.
The diff coverage is 65.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #176      +/-   ##
=========================================
+ Coverage   68.11%   69.2%   +1.09%     
=========================================
  Files          96      95       -1     
  Lines        6890    7005     +115     
=========================================
+ Hits         4693    4848     +155     
+ Misses       2197    2157      -40
Impacted Files Coverage Δ
magpie/adapter/magpieservice.py 0% <0%> (ø) ⬆️
magpie/adapter/magpieprocess.py 0% <0%> (ø) ⬆️
magpie/adapter/__init__.py 0% <0%> (ø) ⬆️
magpie/definitions/typedefs.py 0% <0%> (ø) ⬆️
magpie/adapter/magpieowssecurity.py 0% <0%> (ø) ⬆️
magpie/__meta__.py 100% <100%> (ø) ⬆️
magpie/api/management/user/user_formats.py 100% <100%> (ø) ⬆️
magpie/definitions/ziggurat_definitions.py 100% <100%> (ø) ⬆️
magpie/definitions/sqlalchemy_definitions.py 100% <100%> (ø) ⬆️
magpie/api/management/service/__init__.py 100% <100%> (ø) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45d2af...018c55a. Read the comment docs.

@fmigneault fmigneault requested a review from dbyrns April 13, 2019 01:08
@fmigneault fmigneault merged commit 901a42c into master Apr 15, 2019
@fmigneault fmigneault deleted the formatting branch April 15, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use class "enums" Adjust incorrectly used HTTPNotAcceptable Rename some modules Swagger Improvements
2 participants