version 0.9.0 improvements #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
added
enhancement
fmigneault
force-pushed
the
config-perm-loader
branch
from
9352ccb to
22fcbd5
Compare
dbyrns
reviewed
Feb 1, 2019
| @echo "Starting Magpie..." | ||
| exec gunicorn -b 0.0.0.0:2001 --paste "$(CUR_DIR)/magpie/magpie.ini" --workers 10 --preload | ||
| @bash -c 'source "$(CONDA_HOME)/bin/activate" "$(CONDA_ENV)"; \ | ||
| exec gunicorn -b 0.0.0.0:2001 --paste "$(CUR_DIR)/magpie/magpie.ini" --workers 10 --preload &' |
There was a problem hiding this comment.
That little & at the end of the command looks like a hack, no?
There was a problem hiding this comment.
Tells bash to not wait for the return of the call.
So basically, run the process detached.
| @@ -25,6 +49,11 @@ | |||
| SERVICES_PHOENIX = 'PHOENIX' | |||
There was a problem hiding this comment.
Is this file only related to Phoenix? Because all Phoenix related stuff could be marked as deprecated... and removed as soon as the latest twitcher version is used.
There was a problem hiding this comment.
Indeed, all of Phoenix related code is preserved for back compatibility to old twitcher, but is mostly deprecated now.
fmigneault
force-pushed
the
config-perm-loader
branch
from
fcfca44 to
172bd0d
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAGPIE_LOG_LEVEL >= INFO