Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service API ponctual permissions #109

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Oct 2, 2018

depends on PR #104

  • adds the read-match and write-match permissions to ServiceAPI route resources.
    requested route must be an exact match to ticked permission to pass

  • read/write permissions continue to englobe all sub-resources
    ie: read on /processes will grant read on /processes/...

  • use /users/{id}/services?cascade=True to return services if any of its sub-resources has user permissions

    • otherwise default behaviour remains (direct permissions on service must be set for user to return a given service)
    • can be combined with inherit query
  • start to deprecate /users/.../inherited_<> routes (still available, but will log warnings and such)

  • use /users/.../<>?inherit=True instead to return <> inheriting user's groups permissions

  • change to magpie 0.7.0 since including big change of sync remote

To Do

tag 0.7.0 when this PR, PR #104, PR #106 are merged

@fmigneault fmigneault mentioned this pull request Oct 2, 2018
17 tasks
@fmigneault fmigneault requested review from dbyrns and davidcaron and removed request for dbyrns October 2, 2018 20:37
@fmigneault fmigneault added enhancement Improvements in term of performance or behaviour feature New feature to be developed labels Oct 2, 2018
Copy link
Contributor

@dbyrns dbyrns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the [read, write]-match conversion.

@fmigneault
Copy link
Collaborator Author

Tomorrow, we will need to give a try to a massive merge of all these PRs.

@dbyrns
Copy link
Contributor

dbyrns commented Oct 3, 2018

It will be epic !

@davidcaron
Copy link
Contributor

I will try go ahead with the merge in a new branch and deploy on colibri if everyone is ok

@dbyrns
Copy link
Contributor

dbyrns commented Oct 3, 2018

Good!

@tomLandry
Copy link

Will you tell me about these tales of merging epicness?

@davidcaron davidcaron mentioned this pull request Oct 3, 2018
fmigneault added a commit that referenced this pull request Oct 5, 2018
@fmigneault
Copy link
Collaborator Author

closed via #110

@fmigneault fmigneault closed this Oct 5, 2018
@fmigneault fmigneault deleted the service-api-ponctual-permissions branch December 6, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements in term of performance or behaviour feature New feature to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants