Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bad effective user permission display in UI #463

Closed
tlvu opened this issue Aug 26, 2021 · 2 comments · Fixed by #471
Closed

[BUG] Bad effective user permission display in UI #463

tlvu opened this issue Aug 26, 2021 · 2 comments · Fixed by #471
Assignees
Labels
bug Problem, error, or invalid behaviour ui Something related to the UI operations or display

Comments

@tlvu
Copy link
Contributor

tlvu commented Aug 26, 2021

Describe the bug
Bad effective user permission display in UI only, when executing notebook {pavics-sdi repo}/docs/source/notebooks/pavics_thredds.ipynb it works fine.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy PAVICS stack at tag 1.14.0 (Magpie 3.14.0) with optional-components/secure-thredds enabled
  2. Execute scripts/create-magpie-authtest-user
  3. Go to https://PAVICS_HOST/magpie/ui/users/authtest/thredds
  4. Check "View inherited group permissions and effective user permissions. "

Expected behavior
authtest user effective permission should have been Allow, not Denied as in screenshot.

Screenshots
Screenshot 2021-08-26 at 14-26-51 Magpie

@tlvu tlvu added the bug Problem, error, or invalid behaviour label Aug 26, 2021
@fmigneault
Copy link
Collaborator

Displayed permissions are inherited (aka applied on both user/group for a given resource).
This is not effective which on top of the above, considers the scope modifier.
To test the effective resolution of a specific resource/permission, press the corresponding [?] button.

@fmigneault
Copy link
Collaborator

fmigneault commented Aug 27, 2021

Following demonstrates that authtest is correctly resolved for each permission.

image

That being said, there is still an issue here...
The displayed Deny, Recursive comes from inherited anonymous group.
It seems the displayed inherited permission in this case doesn't consider priority (1) correctly to present the most "important" one, which would be from thredds-secure-authtest-group (2) in this case.

(1):

User[deny] -> User[allow] -> Group[deny](generic) -> Group[allow](generic) -> Group[deny](anonymous) -> Group[allow](anonymous)

(2):
https://github.com/bird-house/birdhouse-deploy/blob/master/birdhouse/optional-components/secure-thredds/secure-access-magpie-permission.cfg#L46-L74

@fmigneault fmigneault added the ui Something related to the UI operations or display label Aug 27, 2021
fmigneault added a commit that referenced this issue Oct 1, 2021
…apply it for UI rendering of highest priority permission (resolve #463)
fmigneault added a commit that referenced this issue Oct 1, 2021
fmigneault added a commit that referenced this issue Oct 2, 2021
… under resources endpoint + add test utils to retrieve perms from HTML resource-tree pages + define test validating displayed perms (fixes #463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem, error, or invalid behaviour ui Something related to the UI operations or display
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants