Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datetime_range_begin & datetime_range_end #325

Merged
merged 9 commits into from
Mar 2, 2021
Merged

datetime_range_begin & datetime_range_end #325

merged 9 commits into from
Mar 2, 2021

Conversation

wibeasley
Copy link
Member

Builds on @pbchase's code in #321 & #323

pbchase and others added 6 commits March 1, 2021 09:45
Add dateRangeBegin and dateRangeEnd to redcap-read-oneshot-eav.R, redcap-read-oneshot.R, and R/redcap-read.R
Add dateRange options to redcap_read functions
@wibeasley wibeasley self-assigned this Mar 2, 2021
@pbchase
Copy link
Contributor

pbchase commented Mar 2, 2021

@wibeasley, I agree with all of these changes and the code tests out fine.

I love the speed of these queries. I can search 477k records and return the 278 records of interest in under 4 seconds.

@wibeasley wibeasley merged commit f3f421a into master Mar 2, 2021
@wibeasley
Copy link
Member Author

wibeasley commented Mar 2, 2021

@pbchase, yeah, that is nice. Thanks for alerting me to this new parameter of this API function.

All your changes are in the master branch now. If you find a corner case that my tests don't cover, please start a new issue and reference #321.

Thanks again for the PR. Closes #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants