You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the behavior: Please provide a clear and concise description of the scenario and the behavior. Be careful not to include tokens, PHI (protected health information), or other information that should not be public!
Certain non-english characters (such as ä) are missed by checkbox_choices()
site_selections<-"1, Hospital A | 2, Hospitäl B | 3, Hospital C"REDCapR::checkbox_choices(site_selections)
#> id label#> 1 1 Hospital A#> 2 3 Hospital C
Specifically this section: \x21-\x7B\x7D-\x7E. Instead of ending the search at character x7E (~), I suggest ending at xAD (¡), though I think a case could easily be made that there is no harm in extending all the way to xFE (■).
As you can tell I've already wasted a bunch of time researched this thoroughly, and I'm happy to submit a PR + test cases since I ❤️ the checkbox_choices() function.
Desktop (please complete the following information):
OS: MacOS Montery 12.6.1
REDCap version: N/A
REDCapR Version: 1.1.0
The text was updated successfully, but these errors were encountered:
I've recognized that non-ascii characters have been weakness/limitation of REDCapR for a while. I rarely encounter them in my projects, and I want to accommodate those who do. But many of my attempts to recruit people who use them haven't gone far (eg, #290, #296, #354).
If anyone would like to be involved, please tell me.
Describe the behavior: Please provide a clear and concise description of the scenario and the behavior. Be careful not to include tokens, PHI (protected health information), or other information that should not be public!
Certain non-english characters (such as
ä
) are missed bycheckbox_choices()
Created on 2023-01-24 by the reprex package (v2.0.1)
Expected behavior: A clear and concise description of what you expected to happen.
checkbox_choices()
should be able to handle these characters, especially considering that REDCap is an international phenomenonSuggested Fix:
Add non-english characters to the regex search pattern in
checkbox_choices()
:REDCapR/R/metadata-utilities.R
Line 119 in 716f4da
Specifically this section:
\x21-\x7B\x7D-\x7E
. Instead of ending the search at characterx7E
(~), I suggest ending atxAD
(¡), though I think a case could easily be made that there is no harm in extending all the way toxFE
(■).See here for complete list of character codes: https://www.codetable.net/
As you can tell I've already
wasted a bunch of timeresearched this thoroughly, and I'm happy to submit a PR + test cases since I ❤️ thecheckbox_choices()
function.Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: