-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected Behavior: Empty dataframe when reading from project with special characters #354
Comments
@lrasmus, thanks for digging into the problem.
|
@lrasmus, I implemented your idea and added the Judging from the lack of responses, I'm guessing you and others don't feel too strongly for the need to add an automatic detection mechanism for encoding, so I went with the simpler route that doesn't require another package dependency. If you or anyone else would like to open a new issue (and reference this one), I'm happy to revisit the issue. If you do, please send me a few simple-ish dictionaries & PHI-free datasets that can be included in the test suite. |
We have loaded data that contains non-ASCII characters. When calling
read
, the data frame is coming back empty:I have traced this back that the
httr::POST
is correctly returning data from the API, but the call tohttr::content
is using the default UTF-8 encoding.The conversion fails, and the data is then returned as empty.
In the current
read
calls, it doesn't appear to allow overriding the encoding. I am happy to propose a fix and submit a PR, but was wondering if we want the user to always explicitly set the encoding, or if the package should try to detect the encoding using something like theuchardet
package:The text was updated successfully, but these errors were encountered: