Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for readr 2.0.0 #343

Closed
wibeasley opened this issue Jul 20, 2021 · 0 comments · Fixed by #346
Closed

Upgrade for readr 2.0.0 #343

wibeasley opened this issue Jul 20, 2021 · 0 comments · Fixed by #346

Comments

@wibeasley
Copy link
Member

A major version of readr was released this morning. Any objections if REDCapR requires that at least version 2.0 of readr (currently, it has to be >- 1.3.1)?

readr now uses the same mechanism that's been in vroom for 2 years. In non-REDCap work, I've been using vroom for big csvs most of that time, and have liked it. But it has some nonconventional retrieval strategies; I don't think will help REDCapR's situation where the dataset has already been retrieved from the server and is in RAM. So I want readr to act conventionally by setting the new force_lazy argument to TRUE. Therefore REDCapR will need to require that 2.0.0 of readr is installed.

Not only will this specific argument be addressed, I think it will reduce corner cases. readr is such a big piece of readr, because that's the component that converts REDCap's text into an R data.frame. I'm not wild supporting two different types of conversion engines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant