-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encapsulate kernel of API interaction #213
Comments
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 29, 2018
wibeasley
added a commit
that referenced
this issue
May 30, 2018
outside of `kernel_api()`. The only exceptions are (a) `httr::upload_file()` and (b) testing structure. ref #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building on #210, I'm refactoring some of the functions so their important piece that interacts with REDCap over curl/httr can be refactored into a reusable function that looks something like:
@nutterb (or someone else who pays attention to this package and contributes ideas & code --sorry I forgot who) suggested at least a year ago to pursue this encapsulation. His/her argument was it (a) produces more reusable & testable code & (b) makes it easier for us to adapt to httr interface changes, of if we need to switch to a new curl-ish package entirely.
Closes #210, because it's included in this issue.
The text was updated successfully, but these errors were encountered: