validated simplify

Thanks, @nutterb. Ref #217
OuhscBbmc · Jun 4, 2018 · ebbc8d8 · ebbc8d8
1 parent 4e53a69
commit ebbc8d8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/R/constant.R b/R/constant.R
@@ -46,6 +46,7 @@
 constant <- function( name, simplify=TRUE ) {
   checkmate::assert_character(name, any.missing=F, min.chars=1L)
   checkmate::assert_subset(name, names(constant_list), empty.ok=F)
+  checkmate::assert_logical(simplify, any.missing=F, len=1L)
 
   # return( constant_list[[name]] )
   sapply(

diff --git a/tests/testthat/test-constant.R b/tests/testthat/test-constant.R
@@ -52,3 +52,25 @@ test_that("missing name", {
     expected_error_message
   )
 })
+
+test_that("bad simplify", {
+  # expected_error_message <- "Assertion on 'simplify' failed: Must be of type 'logical', not 'character'."
+  expect_error(
+    constant("form_complete", simplify="aa"),
+    "^Assertion on 'simplify' failed: Must be of type 'logical', not 'character'\\.$"
+  )
+})
+test_that("missing simplify", {
+  # expected_error_message <- "Assertion on 'simplify' failed: Must be of type 'logical', not 'NULL'. "
+  expect_error(
+    constant("form_complete", simplify=NULL),
+    "^Assertion on 'simplify' failed: Must be of type 'logical', not 'NULL'\\.$"
+  )
+})
+test_that("NA simplify", {
+  # expected_error_message <- "Assertion on 'simplify' failed: Contains missing values (element 1)."
+  expect_error(
+    constant("form_complete", simplify=NA_character_),
+    "^Assertion on 'simplify' failed: Contains missing values \\(element 1\\)\\.$"
+  )
+})