throw error if not successful

ref #372
OuhscBbmc · Nov 22, 2021 · e77e839 · e77e839
1 parent ace93f1
commit e77e839
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/R/redcap-delete.R b/R/redcap-delete.R
@@ -114,6 +114,7 @@ redcap_delete <- function(
       "The REDCapR delete operation was not successful.  The error message was:\n%s",
       kernel$raw_text
     )
+    stop(outcome_message)
   }
 
   if (verbose)

diff --git a/tests/testthat/test-delete.R b/tests/testthat/test-delete.R
@@ -46,23 +46,21 @@ test_that("single-arm-four-records", {
   expect_true(returned_object2$success)
 })
 
+test_that("no-delete-permissions", {
+  testthat::skip_on_cran()
+  skip_if_onlyread()
+  credential  <- retrieve_credential_testing(213L) # Write-project, but  no privileges for deleting records
+
+  records_to_delete <- 1
 
-# test_that("single-arm-four-records", {
-#   testthat::skip_on_cran()
-#   skip_if_onlyread()
-#   credential  <- retrieve_credential_testing(213L) # Write-project, but  no privileges for deleting records
-#
-#   records_to_delete <- 1
-#
-#   expected_outcome_message <- "You do not have Delete Record privileges"
-#   expect_error(
-#     returned_object1 <-
-#       redcap_delete(
-#         redcap_uri        = credential$redcap_uri,
-#         token             = credential$token,
-#         records_to_delete = records_to_delete
-#       )#,
-#     # regexp = expected_outcome_message
-#   )
-#
-# })
+  expected_outcome_message <- "The REDCapR delete operation was not successful.  The error message was:.+You do not have Delete Record privileges"
+  expect_error(
+    returned_object1 <-
+      redcap_delete(
+        redcap_uri        = credential$redcap_uri,
+        token             = credential$token,
+        records_to_delete = records_to_delete
+      ),
+    regexp = expected_outcome_message
+  )
+})