Skip to content

Commit

Permalink
CRAN comments; bump version for release
Browse files Browse the repository at this point in the history
  • Loading branch information
wibeasley committed May 18, 2017
1 parent 25adabc commit 7150118
Show file tree
Hide file tree
Showing 7 changed files with 160 additions and 137 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Description: Encapsulates functions to streamline calls from R to the REDCap
University. The Application Programming Interface (API) offers an avenue
to access and modify data programmatically, improving the capacity for
literate and reproducible programming.
Version: 0.9.7.9002
Date: 2017-03-27
Version: 0.9.8
Date: 2017-05-18
Authors@R: c(person("Will", "Beasley", role = c("aut", "cre"), email =
"[email protected]"), person("David", "Bard", role = "ctb"),
person("Thomas", "Wilson", role = "ctb"), person(given="John J",
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# Monday Morning, 2017-03-27: please see [problem w/ curl 2.4](https://github.com/OuhscBbmc/REDCapR/issues/154) issue.

| [GitHub](https://github.com/OuhscBbmc/REDCapR) | [Travis-CI](https://travis-ci.org/OuhscBbmc/REDCapR/builds) | [AppVeyor](https://ci.appveyor.com/project/wibeasley/redcapr/history) | [Coveralls](https://coveralls.io/r/OuhscBbmc/REDCapR) |
| :----- | :---------------------------: | :-----------------------------: | :-------: |
| [Master](https://github.com/OuhscBbmc/REDCapR/tree/master) | [![Build Status](https://travis-ci.org/OuhscBbmc/REDCapR.svg?branch=master)](https://travis-ci.org/OuhscBbmc/REDCapR) | [![Build status](https://ci.appveyor.com/api/projects/status/0i41tn0n2jo4pd2k/branch/master?svg=true)](https://ci.appveyor.com/project/wibeasley/redcapr/branch/master) | [![Coverage Status](https://coveralls.io/repos/OuhscBbmc/REDCapR/badge.svg?branch=master)](https://coveralls.io/r/OuhscBbmc/REDCapR?branch=master) |
Expand Down
15 changes: 6 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
Description
-----------------------------------------------
This submission addresses breaking builds related to changing packages underneath. It also adds new features. In response to Kurt's request this morning, the example url `http://<*your server name*>/redcap/api/help` has been encolsed in a code block, so it doesn't show up in the check.
This submission addresses breaking tests related to changing packages underneath (mostly the curl package I think; described in #154). Kurt had requested that I update the CRAN version a few weeks ago. I made the changes and was waiting until [dplyr 0.6.0](https://blog.rstudio.org/2017/04/13/dplyr-0-6-0-coming-soon/) was released on CRAN, since dplyr is used in several important places. But the release date appears to have been pushed back, and the RTools checks are working with the dev version anyway.

Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley


Test environments
-----------------------------------------------

* Local Ubuntu, R 3.3.1 patched
* Local Win8, R 3.3.1 patched
The win-builder and a local machine have used the CRAN version of dplyr. The others have used the current GitHub master version of dplyr.

* Local Ubuntu, R 3.4.0 patched
* Local Win8, R 3.4.0 patched
* Local Win8, R 3.4.0 devel
* [win-builder](http://win-builder.r-project.org/K3oV4Wlpmp0c/) (version="R-devel")
* [win-builder](https://win-builder.r-project.org/3wAMI67afYVu/) (version="R-devel")
* [Travis CI](https://travis-ci.org/OuhscBbmc/REDCapR), Ubuntu 12.04 LTS
* [AppVeyor](https://ci.appveyor.com/project/wibeasley/REDCapR), Windows Server 2012

Expand All @@ -25,11 +27,6 @@ R CMD check results

* No other unexplainable NOTEs on the other builds.

* It doesn't appear to be an official "NOTE", but there is a message about 1 invalid URLs producing a "libcurl error code 6". This is a fake url that demonstrates how to built one to their own REDCap server: `http://<*your server name*>/redcap/api/help`.

* It doesn't appear to be an official "NOTE", but there is a message about 2 invalid URLs producing a 403-Forbidden status. These are links to the private REDCap forums. These URLs are intentional and unavoidable; they lead to some very good information that's secured by the REDCap server developers. Almost everyone using this REDCapR package will have access to the REDCap forums. And if they're not in contact with an admin on their campus who has access to the wiki, there's a decent chance they're using the server without a license agreement. I've kept the count of the invalid links to a minimum (once per function), and suggested how the user should preocde if they don't have access. These URL messages appear in the checks on some machines/builds, but not all.
* https://community.projectredcap.org/articles/456/api-documentation.html
* https://community.projectredcap.org/articles/462/api-examples.html

Downstream dependencies
-----------------------------------------------
Expand Down
Loading

0 comments on commit 7150118

Please sign in to comment.